search

debangs / RSAGA

RSAGA Package Code
GNU General Public License v2.0
0 stars 2 forks source link

adding vector functions #13

Closed jannes-m closed 8 years ago

jannes-m commented 8 years ago

Hi Donovan,

as promised I've written two vector functions (rsaga.union.polygons, rsaga.intersect.polygons). Additionally, I've updated the documentation, that's why there are so many changes. However, I've deleted the manual part from the NAMESPACE (import, importFrom) and copied it to the DESCRIPTION (see also the recommendation from Hadley at http://r-pkgs.had.co.nz/namespace.html). I hope you are ok with this. This way we can let roxygen create the NAMESPACE automatically. As mentioned before, I have not tested the new functions with previous SAGA versions but you should be able to do so using the examples provided with the functions. If you notice that SAGA used different function arguments or modules in previous versions (which is quite likely), let me know and I'll adjust the functions accordingly.

All the best,

Jannes

debangs commented 8 years ago

Hi Jannes,

Thanks very much for the updates to the DESCRIPTION as well. I will be updating RSAGA to meet SAGA 2.2.7, so this is a great time for incorporating these changes.

Best,

Donovan

From: Jannes Muenchow [mailto:notifications@github.com] Sent: April 26, 2016 08:57 To: debangs/RSAGA RSAGA@noreply.github.com Subject: [debangs/RSAGA] adding vector functions (#13)

Hi Donovan,

as promised I've written two vector functions (rsaga.union.polygons, rsaga.intersect.polygons). Additionally, I've updated the documentation, that's why there are so many changes. However, I've deleted the manual part from the NAMESPACE (import, importFrom) and copied it to the DESCRIPTION (see also the recommendation from Hadley at http://r-pkgs.had.co.nz/namespace.html). I hope you are ok with this. This way we can let roxygen create the NAMESPACE automatically. As mentioned before, I have not tested the new functions with previous SAGA versions but you should be able to do so using the examples provided with the functions. If you notice that SAGA used different function arguments or modules in previous versions (which is quite likely), let me know and I'll adjust the functions accordingly.

All the best,

Jannes

You can view, comment on, or merge this pull request online at:

https://github.com/debangs/RSAGA/pull/13

Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/debangs/RSAGA/pull/13