debangs
commented
8 years ago Hi Jannes,
Thanks for the fix and update! I have been away from RSAGA for a little while, but will be returning to bring it up to SAGA 2.3.1, with these changes included.
I hope you have been having a great summer.
Cheers,
Donovan
From: Jannes Muenchow [mailto:notifications@github.com] Sent: August 23, 2016 08:50 To: debangs/RSAGA RSAGA@noreply.github.com Subject: [debangs/RSAGA] Replace != by all.equal in focal.functions (#15)
Hi Donovan,
I had a few problems with the multi.local.function. It told me I had incompatible input grids due to different cell sizes. However, the cellsize differences were tiny, something like 30 vs. 30.000000001. Therefore, I changed various if-statements by using all.equal instead of !=. I hope that's ok with you.
All the best,
Jannes
You can view, comment on, or merge this pull request online at:
https://github.com/debangs/RSAGA/pull/15
Commit Summary
- replace != by all.equal in the case of cell size
- Merge remote-tracking branch 'upstream/master'
- one should not use all.equal directly in if statements... (use isTRUE)
File Changes
- M R/gridtools.R https://github.com/debangs/RSAGA/pull/15/files#diff-0 (12)
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/debangs/RSAGA/pull/15 , or mute the thread https://github.com/notifications/unsubscribe-auth/AHsHeDZWIbWvtrlu72RxtIWHbS20frNRks5qiuxggaJpZM4Jq4rN .
jannes-m
Hi Donovan,
I had a few problems with the multi.local.function. It told me I had incompatible input grids due to different cell sizes. However, the cellsize differences were tiny, something like 30 vs. 30.000000001. Therefore, I changed various if-statements by using all.equal instead of !=. I hope that's ok with you.
All the best,
Jannes