codepathreview
commented
9 years ago :+1: Great work Debangsu. A few notes after checking out the code:
- Consider use of viewholder pattern inside adapter
- Good to see you properly communicated the user to the user timeline fragment from the profile activity.
- Nicely done architecting the fragments (base class and extension classes) such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ, but you can refactor it more.
- Nice to see you used the
SupportFragmentTabListenerto properly setup the tabs! - Nice use of tag to setup the ability to click the profile image and view a user's profile
- Consider adding progress bars to your app whenever a network request goes out
Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.
This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.
Following the bootcamp, we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next few weeks to get the team project apps in shape for that.
debangsu
Please review the SimpleTwitterClient (aka BasicTwitter) app with fragments, home, mentions, user and third party user profiles and timelines, infinite scrolling with Gingerbread compliance. Thanks.
/cc @nesquena @thecodepath