search

debasishg / scala-redis-nb

Implementation of a non blocking Redis client in Scala using Akka IO
204 stars 38 forks source link

Removing private protection of Reader and Writer in com.redis.serialization.Format.scala #110

Closed patrickcunningham closed 9 years ago

patrickcunningham commented 9 years ago

I would like to remove the private protection of Reader and Writer in the com.redis.serialization.Format.scala file. I believe this would allow more elegant use of the library behind a factory pattern as discussed in this issue: https://github.com/debasishg/scala-redis-nb/issues/109

Please can you consider this for implementation. All opinions and criticisms welcome :)

Patrick

debasishg commented 9 years ago

Thanks .. will take a look over the weekend ..

patrickcunningham commented 9 years ago

Great news! Thank you

Just a couple more tiny questions, what is your release process i.e will this change go into 0.8 release? Do you know when that will be made and deployed to centralised repos Sonatype etc?

debasishg commented 9 years ago

to be honest there's no release plan per se. We do a release once we have a bunch of features / fixes. But this change will go into the next release.

patrickcunningham commented 9 years ago

OK, will keep an eye on the project. Thank you