Disconnections do not fail futures for pending requests

debasishg / scala-redis-nb

Implementation of a non blocking Redis client in Scala using Akka IO

204 stars 38 forks source link

Disconnections do not fail futures for pending requests #80

Open fractaloop opened 10 years ago

fractaloop commented 10 years ago

In the the event of a disconnection, pending request Futures should be failed with a disconnection exception. Right now they will just hang until the timeout expires.

I'm not familiar with the TcpPipelineHandler and it's workings. Is this possible?

guersam commented 10 years ago

It seems possible; however, as Akka IO pipeline has been removed and the pending requests fail eventually, it'd be better to wait until akka-stream lands, so that I can rewrite the TCP pipeline taking this into account.