search

debasishg / scala-redis

A scala library for connecting to a redis server, or a cluster of redis nodes using consistent hashing on the client side.
1.02k stars 219 forks source link

DECRBY, HINCRBY, and INCRBY should all accept Long values #158

Closed bcarl closed 7 years ago

bcarl commented 8 years ago

The documentation for all three of these commands states:

"[The operation] is limited to 64 bit signed integers."

unhydrous commented 7 years ago

Any timelines for this change?

debasishg commented 7 years ago

Thanks for bringing this up. I am just worried about backwards compatibility. What do you suggest ?

unhydrous commented 7 years ago

I think going from Int to Long would be backwards compatible (the other way is not). Worst case perhaps create new functions (decrByL, incrByL for example)?

debasishg commented 7 years ago

actually *byL tends to pollute the API surface. In normal cases Int to Long should be backwards compatible, but I am thinking if there could be any pitfalls. I think I will go for this change and see how people react. In the worst case we can branch.

unhydrous commented 7 years ago

Great, thanks for the quick action!