search

debasishg / scala-redis

A scala library for connecting to a redis server, or a cluster of redis nodes using consistent hashing on the client side.
1.02k stars 219 forks source link

RedisShards.scala silently falls back to non-sharded code #169

Open fizbin opened 8 years ago

fizbin commented 8 years ago

RedisShards.scala (src/main/scala/com/redis/cluster/RedisShards.scala) fails to override some methods from its parent class RedisCommand, making replacing RedisCommand with RedisShards error-prone in ways that are hard to diagnose.

Specifically, we found that RedisShards fails to override the (now-deprecated) call def set(key: Any, value: Any, nxxx: Any, expx: Any, time: Long). It should.

Also, evalBulk should be overridden to either throw an exception or to throw an exception when given more than a single key. (and to then work when given a single key)

There may be other methods that RedisShards fails to override; for safety (to keep from silently falling back to single-sharded code), a simple fix is to override connect in RedisShards to throw an error. E.g.:

override def connect: Boolean = throw new UnsupportedOperationException("Unsupported sharded operation");

At least then such fall-back behavior will be easy to diagnose.

debasishg commented 8 years ago

Thanks for reporting. I am a bit overwhelmed right now with other stuff, but will take a look over the weekend.