Upgrade Apache Commons Pool to version 2.5?

debasishg / scala-redis

A scala library for connecting to a redis server, or a cluster of redis nodes using consistent hashing on the client side.

1.02k stars 219 forks source link

Upgrade Apache Commons Pool to version 2.5? #205

Open jgdodson opened 6 years ago

jgdodson commented 6 years ago

Would this be a welcome change? The current version used is 1.6. Version 2.x (2.5 is most recent) has some performance and scalability improvements. I looked over the docs, and the requisite changes would be minimal. I'd be happy to knock this out.

debasishg commented 6 years ago

+1 .. feel free to send over a PR ..

jgdodson commented 6 years ago

On closer inspection, I've realized that this update will require an annoyingly small change to the constructor of RedisClientPool, so this will need to be placed on the 4.x track, if that's even planned.

debasishg commented 6 years ago

👍