search

debasishg / scala-redis

A scala library for connecting to a redis server, or a cluster of redis nodes using consistent hashing on the client side.
1.02k stars 219 forks source link

Removed RedisShards & cleaned up RedisCluster class #245

Closed atais closed 5 years ago

atais commented 5 years ago

Hi.

After all the cleaning up in #244 I was finally able to see, that actually RedisCluster and RedisShards are the same thing. They just have a different implementation inside.

They both are actually sharding the data across multiple hosts based on the key. Now when the class is 100 lines long it is so easy to see :smile:

This contains #247

@debasishg what do you think?

debasishg commented 5 years ago

@atais Let me dig through the commits and check if there was any diff between clustering and sharding. I will go through it over the weekend and merge .. Thanks for the PR ..