Closed atais closed 5 years ago
should I merge this one only or the other 2 that precedes this as well ?
you can start with this one and the next one is #244
Will it be better to consolidate all the PRs into 1 and remove the redundant ones ?
then please focus on #244 since it contains this one and is my gateway for further improvements :)
merge #244 and close this one
I devided them in logical smaller pieces so it would be easier for you to review.
This is what I have done:
PipelineSpec
had an assertion that sometimes would failSome(0)
depending on client response. Also, fail checks were missingBench
had too short timeout, and somtimes failed.StringOperationsSpec
timeout is same as TTL, which would sometimes failListOperationsSpec
blocking ops in externalRunnable
are nasty code. Fixed withFuture
and blockingfutureValue
BlockingDequeSpec
is the same case asListOperationsSpec
WatchSpec
- the same asListOperationsSpec
PatternsSpec
did not clean up after testsPubSubSpec
had a test that kept the connection alive, and actually is not a testAbout travis:
++{scalaVersion}
also ommited2.10
build which is specified in thesbt
. I think it is best to simply let the sbt do the job.This can be merged before others, I will handle the conflicts.