Update: Missing stream commands XINFO, XADD, XTRIM, XDEL, XRANGE, XREVRANGE, XLEN, XREAD, XGROUP, XREADGROUP. XACK, XCLAIM, XAUTOCLAIM, XPENDING

debasishg / scala-redis

A scala library for connecting to a redis server, or a cluster of redis nodes using consistent hashing on the client side.

1.02k stars 219 forks source link

Update: Missing stream commands XINFO, XADD, XTRIM, XDEL, XRANGE, XREVRANGE, XLEN, XREAD, XGROUP, XREADGROUP. XACK, XCLAIM, XAUTOCLAIM, XPENDING #272

Open zizzle6717 opened 3 years ago

zizzle6717 commented 3 years ago

I think the implementation of many of these methods would be fairly straightforward. I was able to easily extend RedisClient and add them myself, but the issue is using those methods with RedisClientPool which is not so simple. Adding these methods would make them available when using a pool.

I will gladly open a PR if there is no reason not to add these commands. Thank you!

zizzle6717 commented 3 years ago

Others include BZPOPMIN, BZPOPMAX...

and for streams...

XINFO, XADD, XTRIM, XDEL, XRANGE, XREVRANGE, XLEN, XREAD, XGROUP, XREADGROUP. XACK, XCLAIM, XAUTOCLAIM, XPENDING https://redis.io/commands#stream

zizzle6717 commented 2 years ago

Here is a PR to add the missing sorted set commands, https://github.com/debasishg/scala-redis/pull/273

debasishg commented 2 years ago

Hi @zizzle6717 - should we close this issue ? Does the PR handle all parts of the issue ?

zizzle6717 commented 2 years ago

@debasishg I have updated the title, because the PR only added sorted set commands (ZPOPMIN, ZPOPMAX, ETC.)...We are still missing the stream commands