search

debasishg / scala-redis

A scala library for connecting to a redis server, or a cluster of redis nodes using consistent hashing on the client side.
1.02k stars 219 forks source link

feat: Added missing methods: ZPOPMAX, ZPOPMIN, BZPOPMAX, BZPOPMIN #273

Closed zizzle6717 closed 2 years ago

zizzle6717 commented 2 years ago

Does merging kick off a build, test, publish? Or is that a manual process currently?

On Wed, Aug 25, 2021 at 6:40 AM Debasish Ghosh @.***> wrote:

@.**** approved this pull request.

1 nitpick .. LGTM

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/debasishg/scala-redis/pull/273#pullrequestreview-738240990, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXGCEUKT7XIE5IDDB4JODLT6TJCLANCNFSM5CXIYFOA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

debasishg commented 2 years ago

Right now there is no CI on merge. But you can test manually using sbt test that is docker based. I sent u an email just now.

zizzle6717 commented 2 years ago

I fixed my bad tests here, although I see two of the Redis Cluster tests aborted. I could be wrong, but I don't think that points back to any of my changes https://github.com/debasishg/scala-redis/pull/274