search

debasishg / scala-redis

A scala library for connecting to a redis server, or a cluster of redis nodes using consistent hashing on the client side.
1.02k stars 219 forks source link

Bump scalatest, make scala 3 compatible (Ready for review) #279

Closed hughsimpson closed 2 years ago

hughsimpson commented 2 years ago

~The main change here is bumping scalatest, however there are a few other small changes. The common theme is that, once https://github.com/whisklabs/docker-it-scala/pull/146 (or similar version bump pr) is published, the project will build with scala 3~

Cross-compile with scala 3 should now work with artifacts available in maven central. The docker-testkit-impl-docker-java dependency is a beta, but since it's just a test dependency I don't think that should be a blocker

debasishg commented 2 years ago

@hughsimpson https://github.com/whisklabs/docker-it-scala/pull/146 is still Open - any idea when it will be merged ?

hughsimpson commented 2 years ago

Not sure if it'll ever be merged 😓 that repo seems extremely quiet - doesn't seem like any contributions have been merged since 23 Jun 2019. Might be necessary to publish a fork...

EDIT: I emailed someone at whisk, they should be looking at the repo in the next week or so and figuring out the maintainance team, so might be soon 🤞

Edit x2 (11/11): I'm now being told it'll be another week. But they're updating me, so it's on their radar at least

@debasishg That pr has now been merged and released, so this should be ready for review

debasishg commented 2 years ago

@hughsimpson Can u please take a look at the failed github action ? https://github.com/debasishg/scala-redis/runs/4505252759?check_suite_focus=true. The master is broken now ..

hughsimpson commented 2 years ago

Yep it's gone wonky. Not sure what happened there, I'll double-check my end but I'm fairly sure it must've been a shonky release with the docker-testkit-impl-docker-java dependency.

EDIT: Actually, looks like some gigantic pr https://github.com/whisklabs/docker-it-scala/pull/149/files that made massive changes to the API got merged before the releases were cut, so this is probably something we can recover from. It's late for me today, but I'll check this out first thing tomorrow and try to get a fix in. I should've double-checked... Didn't realise they'd made so many additional changes, or I wouldn't have flagged this pr as ready-for-review 🤦