debbiemarkslab / EVcouplings

Evolutionary couplings from protein and RNA sequence alignments
http://evcouplings.org
Other
235 stars 76 forks source link

ValueError: No chains with given name found #49

Closed b-schubert closed 7 years ago

b-schubert commented 7 years ago

I encountered the following error:

Traceback (most recent call last):
  File "/Users/bs224/Dropbox/PostDoc/projects/EVcouplings/test/TestPDB.py", line 33, in test_pbd
    distmap_intra = intra_dists(selected_structures)
  File "/Users/bs224/Dropbox/PostDoc/projects/EVcouplings/evcouplings/compare/distances.py", line 759, in intra_dists
    model
  File "/Users/bs224/Dropbox/PostDoc/projects/EVcouplings/evcouplings/compare/distances.py", line 667, in _prepare_chain
    chain = structures[pdb_id].get_chain(pdb_chain, model)
  File "/Users/bs224/Dropbox/PostDoc/projects/EVcouplings/evcouplings/compare/pdb.py", line 538, in get_chain
    "No chains with given name found"
ValueError: No chains with given name found

which basically breaks the complete pipeline. The culprit was 1OAY...

I propose to ignore the particular PDB structure and continue with the processing via a try and except block. Agreed?

b-schubert commented 7 years ago

See PR #50

thomashopf commented 7 years ago

Can you please describe in a bit more detail in what setting the problem happened? Basically it is trying to access a chain in the structure that the SIFTS mapping claims is there, but is not actually present in the MMTF structure?

I wouldn't be too happy just to ignore the error unless absolutely necessary.

b-schubert commented 7 years ago

Updating the SIFTS file and fasta solved the discrepancy. I suggest I'll update the SIFTS file on orchestra.

thomashopf commented 7 years ago

Okay great that this solves it, the files were a couple of months old already I think....