search

debesha / DoctrineProfileExtraBundle

Bundle to get information about doctrine hydration performance
MIT License
128 stars 16 forks source link

fix: avoid deprecation EntityManager #26

Closed shakaran closed 8 months ago

shakaran commented 8 months ago

Solves the deprecation error:

The "Doctrine\ORM\EntityManager" class is considered final. It may change without further notice as of its next major version. You should not extend it from "Debesha\DoctrineProfileExtraBundle\ORM\LoggingEntityManager".

shakaran commented 8 months ago

@debesha any chance of get this merge soon? it is the last deprecated warning in my codebase for a project

debesha commented 8 months ago

Done, thank you

debesha commented 8 months ago

But I did it already, didn't I? https://github.com/debesha/DoctrineProfileExtraBundle/releases/tag/1.3.9

shakaran commented 8 months ago

it seems that this produces a fatal error, so maybe we need to revert back the release:

PHP Fatal error: Class Debesha\DoctrineProfileExtraBundle\ORM\LoggingEntityManager cannot extend interface Doctrine\ORM\EntityManagerInterface in /vendor/debesha/doctrine-hydration-profiler-bundle/ORM/LoggingEntityManager.php on line 27

shakaran commented 8 months ago

it should be a implements instead extends