search

debiantarte / feudal-overlords

A game about conquering territories and vassalize their Lords to achieve one's ends.
1 stars 0 forks source link

Display result of attack clearly #20

Closed matthias4217 closed 5 years ago

matthias4217 commented 5 years ago

not in the terminal

matthias4217 commented 5 years ago

Maybe make a window pop

debiantarte commented 5 years ago

there are notifications now, could be enough

matthias4217 commented 5 years ago

Yup, awesome ! Also it's still maybe buggy ? Turn 1: Princess Luna conquers AI ... Turn 2: AI move troops to Princess Luna capital, but it shows as AI conquered Princess Luna. And I think the movement is broken again. I thought I had fixed it.

debiantarte commented 5 years ago

Ah yes, we either need to change the return type of attack functions to be able to display different notifications when it's just a movement, or we could do a more decoupled notification system but we may not have enough time for that :/

debiantarte commented 5 years ago

But on the movement and conquest side, everything seems fine on my end. Weird.

debiantarte commented 5 years ago

Should be pretty much sufficient now I guess..?

debiantarte commented 5 years ago

Notification still need to be redone !

debiantarte commented 5 years ago

quite done !