search

debitoor / chai-subset

"containSubset" object properties matcher for Chai
http://chaijs.com/plugins/chai-subset/
MIT License
82 stars 20 forks source link

It should fail if a filled array is expected to contain an empty array as a subset #19

Closed taromero closed 8 years ago

taromero commented 8 years ago

I think that ['1'].should.containSubset([]) should fail, and it's currently passing without errors.

MarkHerhold commented 8 years ago

I disagree. In set theory, all sets contain the empty set. On Nov 3, 2015 12:49 PM, "taromero" notifications@github.com wrote:

I think that ['1'].should.containSubset([]) should fail, and it's currently passing without errors.

— Reply to this email directly or view it on GitHub https://github.com/debitoor/chai-subset/issues/19.

eagleeye commented 8 years ago

I agree with @MarkHerhold

taromero commented 8 years ago

Fair enough, I think I might create a fork for this one.