search

debois / elm-mdl

Elm-port of the Material Design Lite CSS/JS library
Apache License 2.0
965 stars 133 forks source link

Button.link with wrong example in package documentation #293

Closed alehostert closed 7 years ago

alehostert commented 7 years ago

Hello.

The example in Button.link documentation don't work:

Button.render Mdl [0] model.mdl
  [ Button.link
  , Options.attribute <|
      Html.Attributes.href "#some-url"
  ]
  [ text "Link Button" ]

But, the example in [Demo Button Page]() works:

Button.render Mdl [9, 0, 0, 1] model.mdl
  [ Button.ripple
  , Button.colored
  , Button.raised
  , Button.link "#grid"
  ]
  [ text "Link" ]

The issue is just to fix the example on documentation, adding the String argument Button.link is expecting.

aforemny commented 7 years ago

This is fixed in new-v8 (05429195be7cb73ad38dcc94326473a73af4c987). Thanks!