search

debois / elm-mdl

Elm-port of the Material Design Lite CSS/JS library
Apache License 2.0
965 stars 133 forks source link

Fix : hide Grid.All #350

Closed ashishnegi closed 7 years ago

ashishnegi commented 7 years ago

Add all elm-mdl--hide-* classes when hide with Grid.All devices is used.

Current : When we use Grid.hide Grid.All we don't add any hide class for the device. Expected : We should add hide class for all devices.

Use case :

in elm grid : I may add hide Style on the grid Cell based on some logic. E.g. on press state of a help-button, we want to show a help message. so, to logic of showing help message used Grid.hide Grid.All with a condition.

Grid.cell [ if model.showHelpMsg 
               then Grid.size Grid.All 12 
               else Grid.hide Grid.All 
                ] 
               [ .. view .. ]
aforemny commented 7 years ago

Merged in 21b17feb37baf413b5eb5f31ef53e37ae7f90c98. Thanks a bunch!