deboorn / expbackoffworker

Adds automatic exponential backoff to Laravel 5's queue worker
Apache License 2.0
7 stars 3 forks source link

Add support for Laravel 6 #5

Closed dbhynds closed 4 years ago

dbhynds commented 4 years ago

Description

Add support for Laravel 6.

Motivation and context

Laravel 6 is an LTS release. Several other packages in our ecosystem require >=6, so in order to continue using this package, we needed to add support Laravel 6.

How has this been tested?

I've manually tested that this works for both Laravel 5.8 and 6. I was originally nervous about passing in an extra argument to the worker's constructor, but it turns out, PHP lets you pass additional arguments to the constructor, even if it doesn't explicitly accept them. I guess that's PHP for ya.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

Checklist:

I didn't add tests, because there's nothing really to add, but I manually tested it.

dbhynds commented 4 years ago

@deboorn Could you create a new release so that packagist picks up the changes in this PR? We're still using my fork of your repo because packagist hasn't been updated.

EricTendian commented 4 years ago

@dbhynds I just made a new release, so Packagist should update shortly. https://github.com/deboorn/expbackoffworker/releases/tag/v2.2

deboorn commented 4 years ago

Sorry for the late reply. Currently traveling with family. @dbhynds https://github.com/dbhynds - I've added you to the project.

On Mon, Aug 17, 2020 at 11:57 PM Eric Tendian notifications@github.com wrote:

@dbhynds https://github.com/dbhynds I just made a new release, so Packagist should update shortly. https://github.com/deboorn/expbackoffworker/releases/tag/v2.2

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/deboorn/expbackoffworker/pull/5#issuecomment-675234524, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKWH32W4NXKUYOQWD5MGCTSBH3Y5ANCNFSM4NYQLDJQ .

--

Rapid Digital LLC

This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited.