debops / ansible-apt

Configure and manage APT Package Manager
GNU General Public License v3.0
10 stars 15 forks source link

Cleanup template #88

Closed ypid closed 7 years ago

ypid commented 7 years ago

Redundancy ? :wink:

Ups. Yeah, I guess. The role is not tagged yet, so there's still time to fix that.

Ref: https://github.com/debops/ansible-apt/pull/87#discussion_r108154006

Doing that then. I don’t think we should accept such redundancy in the DebOps codebase. That just makes extending/maintenance more difficult and looks ugly. Or if we need to do this then at least do it in one place (debops__tpl_macros.j2). We can do better. DebOps should be unicorns all the way :wink:

@drybjed Refer to "macro flattened()" :wink: I will tested that macro also with other roles. You can wait with merging. I will update this in other roles, test it and open few more PR. It can be merged all at once when it does not break anywhere.

Ref: https://github.com/debops/debops-playbooks/pull/351

ypid commented 7 years ago

Thanks for the review :+1: Fixed.