Closed carlalexander closed 8 years ago
Found a typo running some tests. Don't merge yet. Will update PR.
Fixed the issue :)
Very nice. Although, do you think that you could move the template documentation into the docs/defaults-configuration.rst
file? That way you can also provide some examples how to use the templates, and everything is in one place.
Sure, I'll rework the documentation. :smile:
Alright! Updated the PR. I added everything to docs/defaults-configuration.rst
, but kept the doc in the templates as well. I find it useful in debops.nginx
. Do you prefer I take it out?
I also added some more configuration options and I found a few bugs during testing.
@carlalexander Thanks! The documentation in templates was an old idea I played with but it seems that it's less accessible than documentation using RTFD, which can be searchable and you can provide examples easily. So I want to remove the documentation in debops.nginx
and switch it to RTFD at some point. IMO you can remove the duplicate docs in the templates, but I won't hold it against you. :-)
Here you go! I fixed the typo and removed the documentation in the templates. :smile:
Great, thank you. I'll update the documentation and make a new release on the weekend.
First pass at #3. This adds the ability to create custom actions and filters using dictionaries. This should replace the need for a lot of the files that are in the role.
For example,
owncloud.local
should be generated bydebops.owncloud
. I didn't remove it yet, but that's something that could be done once the PR gets merged.