debops / ansible-owncloud

Install and manage ownCloud instance
GNU General Public License v3.0
34 stars 26 forks source link

Remarks to documents app and smbclient installation #70

Open ghost opened 7 years ago

ghost commented 7 years ago

Hi,

just a few notes / remarks:

Documents app

## https://doc.owncloud.org/server/9.0/admin_manual/configuration_files/collaborative_documents_configuration.html
## Is it necessary to install all LibreOffice packages? https://github.com/owncloud/documents#known-issues
## Upstream documentation does not specify it more clearly. Installing ``libreoffice`` just to be sure.
- '{{ [ "libreoffice" ] if (owncloud__app_documents_enabled|bool) else [] }}'

https://github.com/debops/ansible-owncloud/blob/v0.3.0/defaults/main.yml#L34-L37

The documents app doesn't need LibreOffice for basic functionality. Only if MS Office support is needed LibreOffice needs to be installed and configured like described in the first docs above.

If the latter is wanted the following package command works for me and i didn't had to install the complete libreoffice package:

apt-get install --no-install-recommends libreoffice-writer

SMB support

- '{{ [ "smbclient" ] if (owncloud__smb_support|bool) else [] }}'
- '{{ [ "libsmbclient" ] if (owncloud__smb_support|bool and owncloud__release | version_compare("9.0", ">=")) else [] }}'

https://github.com/debops/ansible-owncloud/blob/v0.3.0/defaults/main.yml#L39-L40

On recent oC versions its highly advised to install the https://github.com/eduardok/libsmbclient-php instead of using the smbclient binary fallback. Ref: https://github.com/owncloud/documentation/issues/2679

ypid commented 7 years ago

Thanks!

Documents app

I figured that out by now :wink: That is why I recently split control over the documents app into two variables owncloud__app_documents_enabled and owncloud__app_documents_libreoffice_enabled. About libreoffice-writer, is that really enough. Did you try those proprietary spreadsheet formats?

SMB support

I saw that. This should fix it I hope? (Next variable in the default file)

owncloud__base_php_packages:
  - '{{ [ "libsmbclient" ] if (owncloud__smb_support|bool and owncloud__release | version_compare("8.9.9", "<=")) else [] }}'

Status

Thanks again. The docs will need to be enhanced based on your input. I will keep that in mind when I next update the role.

ghost commented 7 years ago

Hi,

Did you try those proprietary spreadsheet formats?

the documents app is currently not supporting MS spreadsheets but only .doc and .docx documents. For those the libreoffice-writer is enough and works as expected at my 9.0.5 instance (some one might also want to check that on recent 9.1.1 installation.

The admin backend of oC provides a "MS Word support (requires openOffice/libreOffice)" part with a "Apply and test" button. Once this gets a green "Saved" feedback next to the button all is good and the correct packages are installed.

I saw that. This should fix it I hope? (Next variable in the default file)

I think libsmbclient is not enough in this case. Thats a support lib:

https://packages.debian.org/search?keywords=libsmbclient

which gets used by the actual php module:

https://packages.debian.org/search?keywords=php-smbclient

The php-smbclient is the one provided at https://github.com/eduardok/libsmbclient-php

Unfortunately there package names are a bit messy here. :-/

ypid commented 7 years ago

Thanks very much for the clarification! About libreoffice-writer I will check that and change it in the defaults.

About php-smbclient I saw that when I checked, I remember. The problem is that it has not been backported to Debian stable (jessie), so it is currently not preferred. I will see if that might solve some syncing problems. I will look into that when issues arise.