search

debops / ansible-pki

Bootstrap and manage internal PKI, Certificate Authorities and OpenSSL/GnuTLS certificates
GNU General Public License v3.0
65 stars 29 forks source link

Rework 2 #81

Closed ypid closed 7 years ago

ypid commented 7 years ago

Status: Ready for review and merging Related to: #70 Fixes: #82 Closes: #83

ser commented 7 years ago

Hi guys, I am really unable to test it now, as I don't have a test environment ready and time pressure of my work duties is huge at the moment :( Sorrrrrry

ypid commented 7 years ago

@ser Don’t worry. I tested it and was able to simplify your example a bit :wink:

ypid commented 7 years ago

Tested ACME, self-signed certs and internal CA. Works nicely. You rock @drybjed :+1: You can check this PR when you have time. Should be ready for merging finally :wink:

drybjed commented 7 years ago

Thanks, will do when I have time. Currently on vacation for a week. 17 wrz 2016 18:50 "Robin Schneider" notifications@github.com napisał(a):

Tested ACME, self-signed certs and internal CA. Works nicely. You rock @drybjed https://github.com/drybjed 👍 You can check this PR when you have time. Should be ready for merging finally 😉

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/debops/ansible-pki/pull/81#issuecomment-247787844, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_t9tLVCVvJeByCsjbp7rTCivyotyuTks5qrBo8gaJpZM4JlzKQ .

drybjed commented 7 years ago

I suppose that adding more examples of different certificate types in the documentation could be useful. @ypid, do you plan to add more?

ypid commented 7 years ago

@htgoebel Thanks! I incorporated your feedback.

do you plan to add more?

Currently not but I also like examples and when I find other good once in my own use I will add them.