Closed reixd closed 5 years ago
If I can give my opinion on this, I will prefer to see examples related to debops in the debops monorepo in an examples dir as we already spoke about @drybjed.
For a very simple script, it this review very very thorough :D
@reixd Believe me, this is not a through review. :-) A comprehensive review would point out different coding style mistakes, issues with text formatting, capitalization of words, etc (not much of that here, don't worry). However that kind of reviewing can fly only in big, estabilished projects like the Linux kernel, for example - some piece of code sometimes takes months to get into the kernel. DebOps is a very small project which I care about, but creating too high barrier to entry for submitting new code into the project might discourage people to contribute to it, so I'm very lenient in such cases.