Please review

[deborshisaha]

My app is complete, please review. /cc @codepathreview @codepath

Thank you very much.

[deborshisaha]

I ran out of github space quota. I am not able to upload gif. Working on it.

[nesquena]

I ran out of github space quota. I am not able to upload gif. Working on it.

Upload to Imgur and then copy over the Image URL with a gif extension rather than gifv

[codepathreview]

:+1: Congrats on completing the third project! Great work overall.

• Your attention to UI/UX was impressive.
• Good to see you were able to format the timestamp cleanly
• Good to see you refreshed the timeline after composing a new tweet
• Nice touch with the character count being displayed while the user composes a tweet
• Nice to see you used a SwipeRefreshLayout library for easy timeline refreshes
• Glad to see you made the compose activity into a dialog instead
• Good to see you added ActiveAndroid annotations to the models
• Great job embedding media image in tweet object
• Consider adding progress bars to your app whenever a network request goes out

I have provided a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, Models, Authentication, API Communication, Preferences, ActionBar, et al) and see how they all fit together.

[deborshisaha]

My app is complete, please review. /cc @codepathreview @codepath

Thank you very much.

[deborshisaha]

I uploaded the gif in impute but can't seem to locate it.

[codepathreview]

:+1: Project looks good, glad you were able to finish all required stories

• Architecting the fragments (base class and extension classes) should be done such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ, you have a lot of code duplication
• Good to see you properly communicated the user to the user timeline fragment from the profile activity.
• Nice to see you used the ViewPager to properly setup the tabs!
• Good to see you played with styling
• Consider adding progress bars to your app whenever a network request goes out

We have provided a detailed Twitter Redux Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr using the same patterns.