Closed filip-debricked closed 3 months ago
I can't find the code for excluding all files and directories starting with ".". If we decided to not implement that, what was the reason?
As the description in the issue suggest that would be too inclusive (or exclusive, depending on how you see it), I implemented that with a regex first, but we lost a lot of valuable files for java and c# so its safer to only add the ones we know we want to ignore - even though its more tedious and results in a rather ugly long list. Maybe it should be a config file in the future, but its not that bad yet I think :)
As the description in the issue suggest that would be too inclusive (or exclusive, depending on how you see it), I implemented that with a regex first, but we lost a lot of valuable files for java and c# so its safer to only add the ones we know we want to ignore - even though its more tedious and results in a rather ugly long list. Maybe it should be a config file in the future, but its not that bad yet I think :)
I see, just making sure we didn't miss anything. The code is already an improvement so I'll approve it as soon as the .so files are excluded, which Klara mentioned
View detailed results in CodeScene
Code Health Quality Gates | ✅ OK |
Recommended Review Level | Lightweight sanity check |
Declining Code Health | 0 findings(s) 🚩 |
Improving Code Health | 0 findings(s) ✅ |
Affected Hotspots | 1 files(s) 🔥 |
@filip-debricked did you check the database for the most common files (hashes) across multiple pURLs?