search

debricked / cli

Debricked's command line interface. It brings open source security, compliance and health to your project via the command prompt.
MIT License
21 stars 9 forks source link

log cases where no manifest or lock files were found. Provides detail… #246

Closed ghost closed 4 months ago

ghost commented 4 months ago

…s as to why no files were found.

ghost commented 4 months ago

@sweoggy Want me to add a test for the printing of strictness filter as well?

Also, let me know if you have any disagreements about the PR itself as well. I find it immensely useful to improve our communication in cases where we don't find any files. Currently, nothing is printed at all in these cases, leading to confusion as to why the CLI "fails". In most cases, it's a matter of the code being filtered out by a default exclusions, but nothing is communicated to the end-user.

sweoggy commented 4 months ago

@sweoggy Want me to add a test for the printing of strictness filter as well?

Also, let me know if you have any disagreements about the PR itself as well. I find it immensely useful to improve our communication in cases where we don't find any files. Currently, nothing is printed at all in these cases, leading to confusion as to why the CLI "fails". In most cases, it's a matter of the code being filtered out by a default exclusions, but nothing is communicated to the end-user.

I think it looks good! Test would be good

sweoggy commented 4 months ago

test fails, otherwise looks good :+1:

github-actions[bot] commented 4 months ago

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.03 (9.51 -> 9.48)

View detailed results in CodeScene

🚩 Declining Code Health (highest to lowest):