debricked / dmarc-visualizer

Analyse and visualize DMARC results using open-source tools
Apache License 2.0
658 stars 163 forks source link

Maybe Update? #1

Open dwt opened 4 years ago

dwt commented 4 years ago

Hi there,

thank you so much for your blog post, it helped me a lot getting my own dmarc visualiser up and running. I've actually created a fork here https://github.com/dwt/dmarc-visualizer where I've simplified the docker file to build less local containers and use bind-mounts instead to get config files into the containers. I've also added a makefile to drive configuration and especially allow use with podman-compose to easily deploy it rootless.

What do you think? I'd love to get this into a pull-request or maybe get the guy from parsedmarc to add this to his documentation.

Best Regards, Martin Häcker

zozs commented 4 years ago

Hi!

Sorry for the silence, I just came back from a vacation, but your fork sounds really promising! I'll take a look at it as soon as I have the time, and see if I can merge it :slightly_smiling_face:

Best regards, Linus

dwt commented 4 years ago

I'd love to hear what you think - for sure there is still some extraneous code in there, but it is what I have currently deployed and am working on as I'm working on my deployment.

For sure it can be refined further. :-)

ClearPathDigital commented 4 years ago

@dwt and @zozs How do I connect either of these projects to an IMAP or POP account containing the reports? Can we get some documentation?

@dwt I am unable to comment on your fork of this because you don't have Issues enabled.

Thanks!

dwt commented 4 years ago

@ClearPathDigital: My fork has specific config variables for the IMAP settings and will auto-generate a config file from that. Have a look at the code!

I've not yet enabled issues, because I was hoping to only have a short lived repository. Lets see if I change that.

ClearPathDigital commented 4 years ago

@dwt, yes I have already done exactly that: I looked at the code. I put the config variables in place using the text files listed in the code. The parsedmarc process took a while to run. It seems to have accessed my mailbox with the reports in it, because they've all been marked as read. But, ultimately I got an error back and no data in grafana: ERROR:cli.py:605:IMAP Error: 285

dwt commented 4 years ago

@dwt https://github.com/dwt, yes I have already done exactly that: I looked at the code. I put the config variables in place using the text files listed in the code. The parsedmarc process took a while to run. It seems to have accessed my mailbox with the reports in it, because they've all been marked as read. But, ultimately I got an error back and no data in grafana: ERROR:cli.py:605:IMAP Error: 285

Hm, the setup is what I’m running, so I’m a bit lost. If the reports are read, accessing the mailbox should be fine?

You probably have to debug this down to what that error actually means. Sorry mate.

zozs commented 4 years ago

Hi @dwt !

I've taken a look at your repo, and I think you have made some great enhancements!

A few thoughts:

I'd be happy to merge a PR after discussing the above a bit :)

dwt commented 4 years ago

Hi @zozs,

PRs would be more than welcome - what would be the easiest way to work on this? If we work with branches, I'd love to give out push access to my repo to prepare this? We could also work on branches on this repo? What would you prefer?

dwt commented 4 years ago

@zozs ping? I'd love have some progress on this, ideally with some input from you. So, could you spend some time to answer some of my questions?

zozs commented 4 years ago

@dwt sorry for the slow answer! I've had limited time to spend on this project the last month unfortunately.

With regard to the work flow, we could work in a branch in your repo, and then when finished, we could just create a PR and merge it back into this repo. I think that would be a reasonable solution?

dwt commented 4 years ago

I'll get you invited to collaborate on my repo

jsalatiel commented 2 years ago

Any progress on this ?

dwt commented 2 years ago

@jsalatiel sadly not. To be honest, this completely fell through the cracks for me. :-(

@zozs: I did invite you as a collaborator. How can we get this best restarted? What would you like us to complete first to slowly get a merge started.