search

debrouxl / tilibs

TILP (formerly GtkTiLink) can transfer data between Texas Instruments graphing calculators and a computer. It works with all link cables (parallel, serial, Black/Gray/Silver/Direct Link) and it supports the TI-Z80 series (73..86), the TI-eZ80 series (83PCE, 84+CE), the TI-68k series (89, 92, 92+, V200, 89T) and the Nspire series (Nspire Clickpad / Touchpad / CX, both CAS and non-CAS)
http://lpg.ticalc.org/prj_tilp
63 stars 23 forks source link

libticalcs: fix erroneous bashism in configure script #87

Closed eli-schwartz closed 5 months ago

eli-schwartz commented 5 months ago

configure scripts are POSIX /bin/sh scripts and cannot have bash-specific syntax. The test xxx == yyy construct with double equals is a bash-specific alias for single equals. It does exactly the same thing as single equals -- it provides no additional functionality, no behavior changes, it is exactly the same but with an additional alternate spelling. In exchange for doing nothing, it breaks muscle memory when writing POSIX sh scripts and tricks developers into writing the wrong thing.

It should never be used under any circumstances. Ideally it would be removed altogether from GNU bash.

Bug: https://bugs.gentoo.org/723452

debrouxl commented 5 months ago

Right, thanks :) Being a Debian user, I'm aware of the need to try and avoid superfluous bashisms, but that one slipped through... and I even copy-pasted it to tifileutil on the experimental2 branch, boo.

eli-schwartz commented 5 months ago

I believe that Debian unfortunately still configures their dash package without LINENO support, specifically to make GNU autoconf detect it as a "crippled" shell and search for bash to see if it can re-exec using that.

Which means it's hard to actually test this on Debian. :(