cmake: improve LDFLAGS setting and fix build issues for macOS 10.15

debrouxl / tilp_and_gfm

TILP (formerly GtkTiLink) can transfer data between Texas Instruments graphing calculators and a computer. It works with all link cables (parallel, serial, Black/Gray/Silver/Direct Link) and it supports the TI-Z80 series (73..86), the TI-eZ80 series (83PCE, 84+CE), the TI-68k series (89, 92, 92+, V200, 89T) and the Nspire series (Nspire Clickpad / Touchpad / CX, both CAS and non-CAS)

http://lpg.ticalc.org/prj_tilp

111 stars 17 forks source link

cmake: improve LDFLAGS setting and fix build issues for macOS 10.15 #29

Closed adriweb closed 4 years ago

adriweb commented 4 years ago

Adding gtk+-2.0 as deps with pkg-config solves some build issues (harfbuzz missing include dir, at the very least) on macOS 10.15
Pass DEPS_LDFLAGS correctly with PROPERTIES LINK_FLAGS

Note that because pkg_check_modules seems to use ";" as seps instead of leaving spaces sometimes, it breaks some stuff like "-framework Cocoa" on macOS, so we replace ";" by " " manually, and make sure to pass the LDFLAGS quoted.

debrouxl commented 4 years ago

Thanks :) configure.ac has had that pkg-config dep for many years, so I'd say that this was a bug with the CMake definitions.

adriweb commented 4 years ago

Yeah this should have been done that way since the beginning 🤷‍♂️

At least the tilibs CMakeLists pass the LDFLAGS properly already.