search

debruijn / cs2

A project to combine the Counterstrike 2 rankings from ESL, HLTV and Valve.
MIT License
2 stars 1 forks source link

Duplicate teams in rosters.csv #10

Open debruijn opened 2 weeks ago

debruijn commented 2 weeks ago

During this weeks roster update, I noticed that there are duplicate teams in rosters.csv, which seems to line up with teams having multiple names in the different rankings (e.g. "Vitality" / "Team Vitality" or "NAVI" / "Natus Vincere", etc). Probably in update_teamnames_rosters() the mapped_name should be used where now the teamname column/index is used.

I don't have time today to look into this as well so will save this for later.

debruijn commented 2 weeks ago

Note that this doesn't impact the final output, since these different teams are still mapped together later on in unify_data - the issue is only that we are tracking the rosters & roster changes multiple times, once for each unique name the team has across the different rankings. So it's not high priority but a bit confusing.