debruijn / cs2

A project to combine the Counterstrike 2 rankings from ESL, HLTV and Valve.
MIT License
2 stars 1 forks source link

Bug: inconsistent labeling for players at smaller teams not taken into account #5

Open debruijn opened 3 weeks ago

debruijn commented 3 weeks ago

The new functionality in #4 introduced a new csv: player_mapping.csv. This is needed due to inconsistencies in player names across the different rankings, which influences matching the rosters (without for example techno and techno4k would not be considered the same player).

Since there were a lot of players at lower ranked teams that had this problem (namings for them can be even more inconsistent than for higher ranked teams) and I wanted to get this new feature out, I have now ignored those. Ideally, someone goes over all rosters in rosters.csv and checks whether there are obvious cases like techno/techno4k above, and then adds them to player_mapping.csv. Also, rosters.csv would then need to be cleaned up of duplicate rosters that are actually the same ones in the curr_roster and old_rosters columns.