debtcollective / parent

1 stars 0 forks source link

Dispute.markAsCompleted doesn't handle rendering errors correctly #248

Closed orlando closed 5 years ago

orlando commented 5 years ago

If the Dispute rendering fails, the Dispute is still marked as completed, leaving the user with a dispute that has no files and no way to recreate them.

We need to ensure we create the files correctly before completing the dispute.

Notes

https://github.com/debtcollective/dispute-tools/blob/development/models/Dispute.js#L244

Acceptance criteria

orlando commented 5 years ago

@duranmla I'll close this one. Right now if the dispute fails to generate the documents, these will be regenerated when you download it.