search

debtcollective / parent

1 stars 0 forks source link

Header throws error when displaying notifications #253

Closed orlando closed 5 years ago

orlando commented 5 years ago

The vue header is throwing errors when parsing notifications to be displayed. Here's the error

[Vue warn]: Error in render: "TypeError: Cannot read property 'title' of undefined"

found in

---> <ProfileNotification>
       <ProfileDropdown>
         <DebtCollectiveHeader>
           <Root>
warn @ vue.js:597
logError @ vue.js:1739
globalHandleError @ vue.js:1734
handleError @ vue.js:1723
Vue._render @ vue.js:4537
updateComponent @ vue.js:2788
get @ vue.js:3140
Watcher @ vue.js:3129
mountComponent @ vue.js:2795
Vue.$mount @ vue.js:8527
Vue.$mount @ vue.js:10926
init @ vue.js:4131
createComponent @ vue.js:5595
createElm @ vue.js:5542
createChildren @ vue.js:5669
createElm @ vue.js:5571
createChildren @ vue.js:5669
createElm @ vue.js:5571
updateChildren @ vue.js:5832
patchVnode @ vue.js:5923
updateChildren @ vue.js:5809
patchVnode @ vue.js:5923
patch @ vue.js:6083
Vue._update @ vue.js:2670
updateComponent @ vue.js:2788
get @ vue.js:3140
run @ vue.js:3217
flushSchedulerQueue @ vue.js:2981
(anonymous) @ vue.js:1839
flushCallbacks @ vue.js:1760
vue.js:1743 TypeError: Cannot read property 'title' of undefined
    at Proxy.render (index.min.js:1)
    at VueComponent.Vue._render (vue.js:4535)
    at VueComponent.updateComponent (vue.js:2788)
    at Watcher.get (vue.js:3140)
    at new Watcher (vue.js:3129)
    at mountComponent (vue.js:2795)
    at VueComponent.Vue.$mount (vue.js:8527)
    at VueComponent.Vue.$mount (vue.js:10926)
    at init (vue.js:4131)
    at createComponent (vue.js:5595)

This happens for certain users, and it prevents to display all links in the Header

Tasks

Acceptance criteria

duranmla commented 5 years ago

Is needed to make the npm package? I do not see any previous versions of this repo anywhere else, should we wait until having stencil or the full header implemented as we want? maybe just save this fixed version with a tag version into the repo

orlando commented 5 years ago

@duranmla yeah we need to publish a new version of the NPM package, I'll do it when deploying the new version of the tools