search

debugger22 / github-audio

Listen to music generated by events happening across GitHub :octocat: 🎷
https://github.audio
MIT License
1.74k stars 99 forks source link

won't work in safari... #8

Closed MoralCode closed 8 years ago

MoralCode commented 8 years ago

tried listening in safari 9.1.3 on a mid-2011 iMac (OS X El Capitan 10.11.6) and it came up with this: screen shot 2016-10-03 at 7 19 01 pm

disabled all extensions, still the same result. any ideas?

MoralCode commented 8 years ago

i might like to add that it works perfectly on chrome 53.0.2785.143 (64-bit) on the same machine

jayrav13 commented 8 years ago

That's weird - I'm able to replicate this error on Safari Version 9.1 (11601.5.17.1) on a mid-2012 MacBook Pro (OS X El Capitan 10.11.4). The error in console is:

main.js:258: SyntaxError: Unexpected token '>'

Hope this helps in diagnosing - REALLY cool tool!

Cardoso222 commented 8 years ago

I think this problem occurs because safari don't support js arrow function notation. captura de tela 2016-10-04 as 14 42 16

debugger22 commented 8 years ago

Applied a temporary patch. Can anyone please test?

I have macOS Sierra and it works fine on it.

Cardoso222 commented 8 years ago

Well, i try here and still the same. captura de tela 2016-10-04 as 16 01 00

But when i change the line 259 to this: captura de tela 2016-10-04 as 16 07 39

Works!

debugger22 commented 8 years ago

@Cardoso222 Thanks! Can I use it in the code?

debugger22 commented 8 years ago

@Cardoso222 Made the changes. https://github.com/debugger22/github-audio/commit/06e6421d04d92f3f62a22f3fe987211a13f3bc76

Cardoso222 commented 8 years ago

i'm glad to help! @debugger22