debz-g / YAWA-YetAnotherWeatherApp

A simple weather application focused on material UI and API data calls.
MIT License
2 stars 3 forks source link

Improve font, color, text, text style #3

Closed madhurmehta007 closed 2 years ago

madhurmehta007 commented 2 years ago

Use open source fonts which are free to use for project purposes. Keep the text color and style in accordance with Google's Material UI guidelines.

Rishavgupta12345 commented 2 years ago

can I change the app icon to a cool one ???? BECAUSE it is using the old default one .

I am participating in KWOS so please ASSIGN me this issue so that i can contribute

@madhurmehta007 @debz-g

Keshab0100 commented 2 years ago

I would like to do it

debz-g commented 2 years ago

@Rishavgupta12345 Also add some fonts and colours that matches material design too.

Rishavgupta12345 commented 2 years ago

@Rishavgupta12345 Also add some fonts and colours that matches material design too.

that will be a different pull request , I will do the rest part once you merge my first pull request #7

Because the general rule of contribution suggests not to have many code changes and things done under a single pull request

debz-g commented 2 years ago

Yes the general rule suggest not to have many code changes, but just changing the app icon is a very minor code change.

Rishavgupta12345 commented 2 years ago

Yes the general rule suggest not to have many code changes, but just changing the app icon is a very minor code change.

ok will make few more commits to my pull request

Rishavgupta12345 commented 2 years ago

Yes the general rule suggest not to have many code changes, but just changing the app icon is a very minor code change.

now I did many changes check out my pull request #7

debz-g commented 2 years ago

Good work on removing the hardcoded strings and adding a little asthetics to the design @Rishavgupta12345 .

Rishavgupta12345 commented 2 years ago

Good work on removing the hardcoded strings and adding a little asthetics to the design @Rishavgupta12345 .

thanks, I have completed two pull request in total , is my KWOC over ?