search

dec05eba / gpu-screen-recorder-issues

GPU Screen Recorder issue tracker
11 stars 0 forks source link

[ENHANCEMENT REQUEST] #31

Closed polluxau closed 1 month ago

polluxau commented 1 month ago

Describe the enhancement i'd highly recommend looking into amf encoding as amd added radv support for amf encode today

https://github.com/GPUOpen-LibrariesAndSDKs/AMF/releases/tag/v1.4.34

dec05eba commented 1 month ago

This repository is ONLY for reporting issues. Also there is no reason to support amf in addition to vaapi, it's not better in any way to my knowledge.

polluxau commented 1 month ago

Oh ok my bad, you have a enhancement tag so thats why i created it

dec05eba commented 1 month ago

Oh I see. Those are the default ones. I removed them now.

dec05eba commented 1 month ago

Btw, the situation with amf vs vaapi was primarly an obs one, where obs used bad values for vaapi setup for years and that caused the quality to be worse than amf. It was fixed years later. Most people think that amf is better than vaapi because of that, but it's not really the case when you properly configure vaapi. A lot of information online is still from that time.

polluxau commented 1 month ago

Btw, the situation with amf vs vaapi was primarly an obs one, where obs used bad values for vaapi setup for years and that caused the quality to be worse than amf. It was fixed years later. Most people think that amf is better than vaapi because of that, but it's not really the case when you properly configure vaapi. A lot of information online is still from that time.

True i agree :) love vaapi, isnt using quality=5 ffmpeg option all that is rlly needed for near best quality under something like obs?

dec05eba commented 1 month ago

quality=5 is a h264 only option but yes it can improve quality a bit, but for some users it causes stutter in games (https://github.com/dec05eba/gpu-screen-recorder-issues/issues/2) so if amf uses that (the value it maps to in the amd video encoder) then that option cant be used by default anyways. hevc/av1 doesn't have that option and dont need it and you should use hevc/av1 anyways for best quality. The issues obs had had to do with constant bitrate (CBR) parameters. Constant quality (CQP) on the other hand doesn't have the same issues.