dec0dOS / zero-ui

ZeroUI - ZeroTier Controller Web UI - is a web user interface for a self-hosted ZeroTier network controller.
GNU General Public License v3.0
951 stars 152 forks source link

Add tests for NetworkButton component #138

Closed davidlag0 closed 1 year ago

davidlag0 commented 1 year ago

Pull Request type

Please check the type of change your PR introduces:

This is another PR to keep adding tests to the codebase, for the frontend specifically.

What is the current behavior?

Codebase has no tests. This is meant to improve the situation and ease future code changes.

Issue Number: #135

What is the new behavior?

Does this introduce a breaking change?

Other information

davidlag0 commented 1 year ago

When adding tests for utils/IP I recalled there is a PR to add IPv6 support. I have noticed that several functions in utils/IP would need to be updated. I have not checked if code has to be updated elsewhere as well for IPv6 support. At least the file is covered with tests now including tests that show IPv6 is not supported with some functions, which should help to make changes to support IPv6!

dec0dOS commented 1 year ago

@davidlag0, thanks a lot for your work! Seems to be everything is fine, ready to merge now.