dec0dOS / zero-ui

ZeroUI - ZeroTier Controller Web UI - is a web user interface for a self-hosted ZeroTier network controller.
GNU General Public License v3.0
912 stars 146 forks source link

feat: add search, filter, and sortby on network members #150

Open NoobTW opened 1 year ago

NoobTW commented 1 year ago

Pull Request type

Please check the type of change your PR introduces:

What is the current behavior?

lack of filter and sorting.

Issue Number: #45 #120

What is the new behavior?

Add filter, and sortby for network members like the official ZeroTier Central panel.

image

Does this introduce a breaking change?

Other information

I'm not familiar with material-ui, may need some refactor.

dec0dOS commented 1 year ago

Hello, @NoobTW!

Thanks for your PR, but I have found some issues.

First of all, please run yarn lint before committing changes. Seems to be something wrong with the NetworkMembers.jsx component after your changes.

Screenshot 2023-04-16 at 12 26 19

Please check your PR with different network dataset.

drtech981 commented 1 year ago

Before this PR is merged, a couple of suggestions:

  1. There's no need for a Display Filter button. If the search box is populated, filtered results should be displayed. Otherwise all results are displayed. Can also add a CSS Crossmark to clear the Search Field.
  2. Sort should in addition to address and name, atleast include Peer Status and Last Seen.
  3. Again, coloumn titles can be made clickable (ascending>descending>disable sort cycle through as one clicks away) without adding yet another fied for sort reference.

Just some suggestions that might prevent future refactoring, and thanks @NoobTW for the PR!

faymek commented 7 months ago

I hope this feature can be merged soon. Thank you all developers for your enthusiastic contributions.

drno88 commented 5 months ago

UP I hope this feature can be merged soon. Thank you all developers for your enthusiastic contributions.