Open NoobTW opened 1 year ago
Hello, @NoobTW!
Thanks for your PR, but I have found some issues.
First of all, please run yarn lint
before committing changes.
Seems to be something wrong with the NetworkMembers.jsx component after your changes.
Please check your PR with different network dataset.
Before this PR is merged, a couple of suggestions:
Just some suggestions that might prevent future refactoring, and thanks @NoobTW for the PR!
I hope this feature can be merged soon. Thank you all developers for your enthusiastic contributions.
UP I hope this feature can be merged soon. Thank you all developers for your enthusiastic contributions.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
lack of filter and sorting.
Issue Number: #45 #120
What is the new behavior?
Add filter, and sortby for network members like the official ZeroTier Central panel.
Does this introduce a breaking change?
Other information
I'm not familiar with material-ui, may need some refactor.