Closed aruznieto closed 11 months ago
Thanks a lot for your PR, @aruznieto! Please check my code review.
Thanks a lot for your PR, @aruznieto! Please check my code review.
Where is it?
Apologies for the oversight, it appears I forgot to hit the "Finish" button on the code review page. Unfinished code reviews aren't visible to others.
Apologies for the oversight, it appears I forgot to hit the "Finish" button on the code review page. Unfinished code reviews aren't visible to others.
Pushed, can you add dev: commit?
Seems like you have added the
package-lock.json
by mistake. Please delete it from the root. You should also remove croner from the rootpackage.json
file
Done. Sorry
Everything else seems fine! Looks good to me. Have you had a chance to test the croner package to make sure it behaves exactly as expected?
Keep in mind that node-cron
and croner
are implemented quite differently under the hood
Hmm, it looks like the developer is trying to provide an easy drop-in replacement alternative for node-cron: https://croner.56k.guru/migration/#switching-from-node-cron
Everything should be fine
Hmm, it looks like the developer is trying to provide an easy drop-in replacement alternative for node-cron
Yes
Thank you for collaborating, @aruznieto!
Pull Request type
Please check the type of change your PR introduces:
Issue Number: #73
What is the new behavior?
ES6
Does this introduce a breaking change?
Other information
I update the margin of the page to