dec0dOS / zero-ui

ZeroUI - ZeroTier Controller Web UI - is a web user interface for a self-hosted ZeroTier network controller.
GNU General Public License v3.0
951 stars 152 forks source link

dev: es6 + visual mods #170

Closed aruznieto closed 1 year ago

aruznieto commented 1 year ago

Pull Request type

Please check the type of change your PR introduces:

Issue Number: #73

What is the new behavior?

ES6

Does this introduce a breaking change?

Other information

I update the margin of the page to

dec0dOS commented 1 year ago

Thanks a lot for your PR, @aruznieto! Please check my code review.

aruznieto commented 1 year ago

Thanks a lot for your PR, @aruznieto! Please check my code review.

Where is it?

dec0dOS commented 1 year ago

Apologies for the oversight, it appears I forgot to hit the "Finish" button on the code review page. Unfinished code reviews aren't visible to others.

aruznieto commented 1 year ago

Apologies for the oversight, it appears I forgot to hit the "Finish" button on the code review page. Unfinished code reviews aren't visible to others.

Pushed, can you add dev: commit?

aruznieto commented 1 year ago

Seems like you have added the package-lock.json by mistake. Please delete it from the root. You should also remove croner from the root package.json file

Done. Sorry

dec0dOS commented 1 year ago

Everything else seems fine! Looks good to me. Have you had a chance to test the croner package to make sure it behaves exactly as expected?

Keep in mind that node-cron and croner are implemented quite differently under the hood

dec0dOS commented 1 year ago

Hmm, it looks like the developer is trying to provide an easy drop-in replacement alternative for node-cron: https://croner.56k.guru/migration/#switching-from-node-cron

Everything should be fine

aruznieto commented 1 year ago

Hmm, it looks like the developer is trying to provide an easy drop-in replacement alternative for node-cron

Yes

dec0dOS commented 1 year ago

Thank you for collaborating, @aruznieto!