search

dec0dOS / zero-ui

ZeroUI - ZeroTier Controller Web UI - is a web user interface for a self-hosted ZeroTier network controller.
GNU General Public License v3.0
912 stars 146 forks source link

dev: remove workaround for deleting the member #173

Open dec0dOS opened 11 months ago

dec0dOS commented 11 months ago

Deprecate workaround for this: https://github.com/zerotier/ZeroTierOne/issues/859 as It was fixed in https://github.com/zerotier/ZeroTierOne/commit/f8ea7fdc2b734aa3d720fe5c79f7e784c927116f

More info: https://github.com/dec0dOS/zero-ui/blob/559a98850ecec4cc2c39a7720eba39e6aee06572/backend/services/member.js#L173-L192

wongsyrone commented 11 months ago

How about this block

https://github.com/dec0dOS/zero-ui/blob/559a98850ecec4cc2c39a7720eba39e6aee06572/backend/routes/member.js#L72-L86

dec0dOS commented 11 months ago

@wongsyrone, thanks for pointing! This one is also affected.

wongsyrone commented 11 months ago

Another quick thought, my db.json left many zt nodes with deleted set to true, it's better to clean up these leftovers on zero-ui startup. The proposed workflow is to do the member deletion but ignore controller response and delete additional member data and the member entry in db.json.

dec0dOS commented 11 months ago

Currently, I'm still thinking for the proper migrations solution for ZeroUI: https://github.com/dec0dOS/zero-ui/issues/75