Closed aruznieto closed 10 months ago
Hey @aruznieto, I wanted to express my gratitude for your pull request. I'm really impressed with your contributions. However, I noticed that you included the i18n feature in this PR. I'd like to take a closer look at the i18n feature separately before merging it into the project.
Could you please cherry-pick this specific commit (https://github.com/dec0dOS/zero-ui/pull/185/commits/ff2218d03abaf0540b83d3793041335788ad46d0)? You can find a guide on how to do this here: https://stackoverflow.com/questions/25955822/git-cherry-pick-a-single-commit-for-pull-request.
I admit that I may have merged https://github.com/dec0dOS/zero-ui/pull/179 a bit prematurely, which has led to some unexpected errors in non-standard scenarios. The rate limiting feature could potentially disrupt legitimate users when a reverse proxy is in use. Therefore, I believe it's preferable to make rate limiting an opt-in feature rather than having it enabled by default. You can check the discussion on this issue here: https://github.com/dec0dOS/zero-ui/discussions/181. Thanks again for your hard work!
Add keyboard shortcuts to interface.
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #184
Does this introduce a breaking change?
Migration to ES6