feat: loading-page for suspense

dec0dOS / zero-ui

ZeroUI - ZeroTier Controller Web UI - is a web user interface for a self-hosted ZeroTier network controller.

GNU General Public License v3.0

912 stars 146 forks source link

feat: loading-page for suspense #187

Closed aruznieto closed 10 months ago

aruznieto commented 10 months ago

Pull Request type

Added a loading page for react Suspense while loading language.

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

Does this introduce a breaking change?

[ ] Yes
[x] No

dec0dOS commented 10 months ago

Off topic: Did adding i18n increase the loading time? This PR LGTM, really to merge

aruznieto commented 10 months ago

Off topic: Did adding i18n increase the loading time? This PR LGTM, really to merge

No, the time does not increase.

dec0dOS commented 10 months ago

The theme should be loaded first, so that we could use the branded colours. Made a small refactor, the i18n should be also loaded in the App, rather than in the index.