decaf-dev / obsidian-dataloom

Weave together data from diverse sources and display them in different views. Inspired by Excel spreadsheets and Notion.so.
https://dataloom.xyz/
MIT License
913 stars 33 forks source link

Can't edit embedded table open in new window #671

Open Citatap opened 1 year ago

Citatap commented 1 year ago

Describe the bug

Can't edit embedded table (![[note.loom]]) when I open in new window. Nothing happens when I click on the table.

Steps to reproduce

Right click and open a note in new window

Expected behavior

Hope to be able to edit a table in a new window, just like editing a table in a tab.

Are you using the mobile app?

No

Obsidian debug info

SYSTEM INFO: Obsidian version: v1.3.7 Installer version: v1.3.5 Operating system: Windows 10 Pro 10.0.22621 Login status: logged in Catalyst license: none Insider build toggle: off Live preview: on Legacy editor: off Base theme: dark Community theme: none Snippets enabled: 0 Restricted mode: off Plugins installed: 51 Plugins enabled: 19 1: File Explorer Note Count v1.2.1 2: Advanced Tables v0.19.1 3: Local REST API v1.6.0 4: Periodic Notes v0.0.17 5: Remotely Save v0.3.25 6: Templater v1.16.0 7: File Creation and Last Modified Timestamps in Status Bar v1.2.0 8: Calendar v1.5.10 9: Omnisearch v1.15.2 10: Text Extractor v0.4.6 11: KoreanBook Info Plugin v1.3.2 12: Kanban v1.5.3 13: Editing Toolbar v2.3.1 14: Highlightr v1.2.2 15: Obsidian42 - BRAT v0.7.0 16: Mousewheel Image zoom v1.0.19 17: Outliner v4.8.0 18: Image Toolkit v1.3.1 19: DataLoom v8.0.0

RECOMMENDATIONS: Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.

Relevant log output

No response

decaf-dev commented 1 year ago

Please update to data loom 8.1.0

On Sun, Aug 6, 2023, 2:13 PM Citatap @.***> wrote:

Describe the bug

Can't edit embedded table (![[note.loom]]) when I open in new window. Nothing happens when I click on the table. Steps to reproduce

Right click and open a note in new window Expected behavior

Hope to be able to edit a table in a new window, just like editing a table in a tab. Are you using the mobile app?

No Obsidian debug info

SYSTEM INFO: Obsidian version: v1.3.7 Installer version: v1.3.5 Operating system: Windows 10 Pro 10.0.22621 Login status: logged in Catalyst license: none Insider build toggle: off Live preview: on Legacy editor: off Base theme: dark Community theme: none Snippets enabled: 0 Restricted mode: off Plugins installed: 51 Plugins enabled: 19 1: File Explorer Note Count v1.2.1 2: Advanced Tables v0.19.1 3: Local REST API v1.6.0 4: Periodic Notes v0.0.17 5: Remotely Save v0.3.25 6: Templater v1.16.0 7: File Creation and Last Modified Timestamps in Status Bar v1.2.0 8: Calendar v1.5.10 9: Omnisearch v1.15.2 10: Text Extractor v0.4.6 11: KoreanBook Info Plugin v1.3.2 12: Kanban v1.5.3 13: Editing Toolbar v2.3.1 14: Highlightr v1.2.2 15: Obsidian42 - BRAT v0.7.0 16: Mousewheel Image zoom v1.0.19 17: Outliner v4.8.0 18: Image Toolkit v1.3.1 19: DataLoom v8.0.0

RECOMMENDATIONS: Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins. Relevant log output

No response

— Reply to this email directly, view it on GitHub https://github.com/trey-wallis/obsidian-dataloom/issues/671, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJTQYW6JAOASW6R7OPSJLELXT73FTANCNFSM6AAAAAA3GD4K4U . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Citatap commented 1 year ago

Hi Trey, Thank you for your quick response.

I updated to the latest version you mentioned and checked again, but I still can't edit embedded .loom table when I open my note in 'new window'.

Attach my screenshot below. When I click on the table, nothing happens like reading mode.

image

decaf-dev commented 1 year ago

I am guessing that there is a plugin enabled that is causing this behavior. Can you try disabling all plugins except DataLoom and then restart Obsidian? It might be the plugin that creates the status bar.

Citatap commented 1 year ago

I am guessing that there is a plugin enabled that is causing this behavior. Can you try disabling all plugins except DataLoom and then restart Obsidian? It might be the plugin that creates the status bar.

I tried it in 2 ways but failed.

  1. I disabled all plugins except Dataloom in the existing Vault, but it failed. Still can't edit table in a note opened 'in new window'

  2. I created and tried a new Sandbox Vault, but editing in 'new window' is not possible, same as 1.

image

image

image

FYI, debug info

SYSTEM INFO: Obsidian version: v1.3.7 Installer version: v1.3.5 Operating system: Windows 10 Pro 10.0.22621 Login status: logged in Catalyst license: none Insider build toggle: off Live preview: on Legacy editor: off Base theme: dark Community theme: none Snippets enabled: 0 Restricted mode: off Plugins installed: 1 Plugins enabled: 1 1: DataLoom v8.1.0

decaf-dev commented 1 year ago

@Citatap Thanks for that. I was able to reproduce it.

decaf-dev commented 1 year ago

It looks like the menus are appearing on the first window instead of the new one.

Citatap commented 1 year ago

Thanks for looking into the problem!

In my opinion, it seems that Obsidian cannot bring some functions of the plugin that is pulled from the sidebar, if a note is opened in a new window.

decaf-dev commented 1 year ago

I will investigate this further. I am unfamiliar with this functionality in electron.

sn1c3 commented 5 months ago

@trey-wallis did you find a solution? I am also struggling with the editing of a table in a new window.