decaf-dev / obsidian-dataloom

Weave together data from diverse sources and display them in different views. Inspired by Excel spreadsheets and Notion.so.
https://dataloom.xyz/
MIT License
899 stars 32 forks source link

#934 Added command to clear all data in the table: #950

Closed 42ama closed 1 month ago

42ama commented 1 month ago

@trey-wallis hi, could you check the PR please?

The only place I doubt is that I had to duplicate the possible values that can be passed to textVariant. Now there are two places in the plugin where this enumeration is present ("semibold" | "faint" | "muted" | "on-accent" | "error" | "normal"). This is in the MenuItem.textVariant definition and in Text.variant. It would be nice to get this definition into a single place, but I had no idea how. In general, you could put these values in enum, but then backward compatibility and the ability to set the vairant property with string would break.

42ama commented 1 month ago

@trey-wallis Hi, could you check out the PR, please?

42ama commented 1 month ago

@trey-wallis Hi, could you check out the PR, please?

decaf-dev commented 1 month ago

Hi @42ama. I am sorry that I didn't get back to you. I am no longer developing DataLoom. I will be working on other projects from now on. I will post more about this in the README.

I will be closing this request for now.