search

decaf-dev / obsidian-view-count

Add view count tracking to your Obsidian vault
MIT License
12 stars 0 forks source link

Double Increment Per Visit #14

Closed Aetherinox closed 1 month ago

Aetherinox commented 1 month ago

Wondering if I'm missing something.

Was testing out features, and I decided to disable the daily increment. Here is a capture of me switching back and forth between two different notes, and getting +2 on each visit.

fzHtNohoDE

Current settings: eQoVGTuklF

A side note; I've tried both File and Property, with the same results for each. Also enabled / disabled the Delay / Frontmatter setting, and disabled frontmatter. All with restarts after.

decaf-dev commented 1 month ago

This is very weird behavior. Could you installing the view count plugin in the sandbox and trying it there too?

You can do this by opening the command palette (CMD + P) and typing "Open sandbox vault"

Aetherinox commented 1 month ago

So the plugin by itself works.

What is odd is that when I enable the frontmatter title plugin; that's when it goes south and does +2 increments. I'm not sure if the Frontmatter plugin is doing something to double load a page in order to render all of the elements or what it is doing, but it definitely does +2 as soon as the Frontmatter Title plugin is enabled:

And it doesn't increment +2 on every single load. One time it'll increment +1, and then the next +2, and then +2 again, then +1.

Aetherinox commented 1 month ago

I also saw that you released an update to add a delay. I decided to enable that and set it to 5000ms just to see if the delay would solve the issue with ensuring everything is loaded, and that didn't help unfortunately. Still doing +2 per visit.

decaf-dev commented 1 month ago

I just added a fix in 2.0.0. Please let me know if you're still getting the double count

Aetherinox commented 1 month ago

Tested it for a few minutes, it appears to only be adding +1 to each refresh. I'll monitor it for awhile, but thus far, it's working as expected. Including with the Front Matter Title plugin being enabled.

decaf-dev commented 1 month ago

Great news!

On Sat, May 25, 2024, 12:46 PM Aetherinaux @.***> wrote:

Tested it for a few minutes, it appears to only be adding +1 to each refresh. I'll monitor it for awhile, but thus far, it's working as expected.

— Reply to this email directly, view it on GitHub https://github.com/trey-wallis/obsidian-view-count/issues/14#issuecomment-2131389241, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJTQYW4VWX3OF4Q7HMCJQW3ZEDMANAVCNFSM6AAAAABHGZLMVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZRGM4DSMRUGE . You are receiving this because you commented.Message ID: @.***>

decaf-dev commented 1 month ago

I am going to close this issue for now. If the problem arises again, please comment and I will reopen it. Thanks.

Aetherinox commented 1 month ago

Sure thing. I've been keeping an eye on it for a few days now. No issues, so I think we're good. Appreciate it.