search

decafjs / decaf-mongodb

MongoDB module for decaf
MIT License
0 stars 1 forks source link

Typo in latest commit #1

Open mm765 opened 8 years ago

mm765 commented 8 years ago

BSON.js deserialize: toStrring() (double r), other than that, it works for my very small test, thanks.

mm765 commented 8 years ago

Push - This is the one i mentioned in the decaf-thread, but maybe this is fixed in bower, too, so i didn't see it ?!

mschwartz commented 8 years ago

Can you tell me what line number in the file is wrong, what it says and what it should say?

Thanks

mschwartz commented 8 years ago

Bower simply does something like a git clone when you do "bower install." When you do "bower update" it will do the equivalent of a git pull. If you are not using bower, then I can't help more without knowing how exactly you installed things.

On Mon, Jan 18, 2016 at 10:55 AM, mm765 notifications@github.com wrote:

Push - This is the one i mentioned in the decaf-thread, but maybe this is fixed in bower, too, so i didn't see it ?!

— Reply to this email directly or view it on GitHub https://github.com/decafjs/decaf-mongodb/issues/1#issuecomment-172622413 .

mm765 commented 8 years ago

Sorry for the sloppy description. In BSON.js line 61 reads return String(o.toStrring()); it should be return String(o.toString());

mm765 commented 8 years ago

As to how i installed it - i simply cloned the repositories from github. Now when i do a git pull it says i am up to date (for this and also for the decafjs repository) and also github does show the last date of change to be about 10 days ago - so it seems the github repository has not been updated.

mschwartz commented 8 years ago

I don't see the mistake :)

On Mon, Jan 18, 2016 at 2:34 PM, mm765 notifications@github.com wrote:

Sorry for the sloppy description. In BSON.js line 61 reads return String(o.toStrring()); it should be return String(o.toString());

— Reply to this email directly or view it on GitHub https://github.com/decafjs/decaf-mongodb/issues/1#issuecomment-172672006 .

mschwartz commented 8 years ago

NVM, I found it and pushed the typo fix.

On Mon, Jan 18, 2016 at 3:03 PM, Mike Schwartz mykesx@gmail.com wrote:

I don't see the mistake :)

On Mon, Jan 18, 2016 at 2:34 PM, mm765 notifications@github.com wrote:

Sorry for the sloppy description. In BSON.js line 61 reads return String(o.toStrring()); it should be return String(o.toString());

— Reply to this email directly or view it on GitHub https://github.com/decafjs/decaf-mongodb/issues/1#issuecomment-172672006 .

mm765 commented 8 years ago

:) there are two "r"s in the toString Double rr Hope this helps :)

mm765 commented 8 years ago

Ok, and this one also shows up on github and was sent to me on a git pull.

mschwartz commented 8 years ago

I thought so :)

On Mon, Jan 18, 2016 at 3:11 PM, mm765 notifications@github.com wrote:

Ok, and this one also shows up on github and was sent to me on a git pull.

— Reply to this email directly or view it on GitHub https://github.com/decafjs/decaf-mongodb/issues/1#issuecomment-172678018 .