search

decalage2 / oletools

oletools - python tools to analyze MS OLE2 files (Structured Storage, Compound File Binary Format) and MS Office documents, for malware analysis, forensics and debugging.
http://www.decalage.info/python/oletools
Other
2.81k stars 560 forks source link

Relax pyparsing requirement. #812

Closed vEpiphyte closed 2 months ago

vEpiphyte commented 1 year ago

All oletools unit tests pass with pyparsing 3.0.9 installed. This makes it easier to use oletools as a library.

decalage2 commented 1 year ago

If I remember well, the requirement to keep pyparsing 2.x is due to ViperMonkey, which does not work with pyparsing 3 (and requires oletools). But if you only use oletools without ViperMonkey indeed it may work.

vEpiphyte commented 1 year ago

I see that specific constraint for ViperMonkey here https://github.com/decalage2/ViperMonkey/blob/master/requirements.txt#L6

The vipermonkey tests don't currently run python 3 so I haven't explored if any tests fail on pyparsing 3.x yet.

CRogos commented 4 months ago

We are also getting version conflicts in odoo. We need a version that supports pyparsing>3 Couldn't we restrict ViperMonkey to oletools<=60.1?

https://github.com/OCA/social/issues/1316

CRogos commented 3 months ago

I've added a PR https://github.com/decalage2/ViperMonkey/pull/125 to ViperMonkey. @decalage2 I think this project should move on, if it is working with newer pyparsing versions.

gbtechnology commented 2 months ago

@vEpiphyte @decalage2 this has been opened over 1 year ago. Is there something blocking this merge?

vEpiphyte commented 2 months ago

@gbtechnology I am not a maintainer on this project. I cannot merge it.

CRogos commented 2 months ago

@decalage2 will you also release a new version so this change gets available via pip?

johnlandonwood commented 1 month ago

@decalage2 will you also release a new version so this change gets available via pip?

Seconding this, would be a huge help.