search

decaporg / decap-cms

A Git-based CMS for Static Site Generators
https://decapcms.org
MIT License
17.8k stars 3.03k forks source link

Unable to approve pr in the netlify-cms gui #1593

Open ArcaneTSGK opened 6 years ago

ArcaneTSGK commented 6 years ago

- Do you want to request a feature or report a bug? Feature

- What is the current behavior? If the publish branch is a protected branch on GitHub, the content owner is unable to approve the pull request within the netlify-cms gui. Instead they have to go to GitHub and approve the pr there, which breaks their workflow experience.

- What is the expected behavior? As most content teams are not developers or even tech savvy people, they should not be required to go into github to approve a pr, there should be a way to approve the changes within netlify-cms workflow itself.

erquhart commented 6 years ago

Agreed, the GitHub backend should account for this.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

pmpinto commented 3 years ago

Additionally to what @ArcaneTSGK mentioned above, as it wasn't clear for me, I believe the user dragging the changes to the "Ready" column should be the user approving the PR in GitHub (through the backend).

@erquhart Any news on this? This is currently blocking our content team from managing their work themselves and relying on a team of developers to manually approve their content changes on GitHub insert sad kitten

erezrokah commented 3 years ago

Hi @pmpinto, we're open to contributions for this issue. I would say it's a medium size effort to add an approve button to an editorial workflow entry that's only enabled for users that didn't author the entry